class Drupal_Sniffs_Commenting_InlineCommentSniff in Coder 7.2

PHP_CodeSniffer_Sniffs_Drupal_Commenting_InlineCommentSniff.

Checks that no perl-style comments are used. Checks that inline comments ("//") have a space after //, start capitalized and end with proper punctuation. Largely copied from Squiz_Sniffs_Commenting_InlineCommentSniff.

@category PHP @package PHP_CodeSniffer @author Greg Sherwood <gsherwood@squiz.net> @author Marc McIntyre <mmcintyre@squiz.net> @copyright 2006 Squiz Pty Ltd (ABN 77 084 670 600) @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence @version Release: 1.2.0RC3 @link http://pear.php.net/package/PHP_CodeSniffer

Hierarchy

class \Drupal_Sniffs_Commenting_InlineCommentSniff implements \PHP_CodeSniffer_Sniff

Expanded class hierarchy of Drupal_Sniffs_Commenting_InlineCommentSniff

File

coder_sniffer/Drupal/Sniffs/Commenting/InlineCommentSniff.php, line 32

View source

class Drupal_Sniffs_Commenting_InlineCommentSniff implements PHP_CodeSniffer_Sniff {

  /**
   * Returns an array of tokens this test wants to listen for.
   *
   * @return array
   */
  public function register() {
    return array(
      T_COMMENT,
      T_DOC_COMMENT,
    );
  }

  //end register()

  /**
   * Processes this test, when one of its tokens is encountered.
   *
   * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
   * @param int                  $stackPtr  The position of the current token
   *                                        in the stack passed in $tokens.
   *
   * @return void
   */
  public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr) {
    $tokens = $phpcsFile
      ->getTokens();

    // If this is a function/class/interface doc block comment, skip it.
    // We are only interested in inline doc block comments, which are
    // not allowed.
    if ($tokens[$stackPtr]['code'] === T_DOC_COMMENT) {
      $nextToken = $phpcsFile
        ->findNext(PHP_CodeSniffer_Tokens::$emptyTokens, $stackPtr + 1, null, true);
      $ignore = array(
        T_CLASS,
        T_INTERFACE,
        T_FUNCTION,
        T_PUBLIC,
        T_PRIVATE,
        T_PROTECTED,
        T_FINAL,
        T_STATIC,
        T_ABSTRACT,
        T_CONST,
        T_OBJECT,
        T_PROPERTY,
      );

      // Also ignore all doc blocks defined in the outer scope (no scope
      // conditions are set).
      if (in_array($tokens[$nextToken]['code'], $ignore) === true || empty($tokens[$stackPtr]['conditions']) === true) {
        return;
      }
      else {
        $prevToken = $phpcsFile
          ->findPrevious(PHP_CodeSniffer_Tokens::$emptyTokens, $stackPtr - 1, null, true);
        if ($tokens[$prevToken]['code'] === T_OPEN_TAG) {
          return;
        }

        // Only error once per comment.
        if (substr($tokens[$stackPtr]['content'], 0, 3) === '/**') {
          $error = 'Inline doc block comments are not allowed; use "// Comment" instead';
          $phpcsFile
            ->addError($error, $stackPtr, 'DocBlock');
        }
      }

      //end if
    }

    //end if
    if ($tokens[$stackPtr]['content'][0] === '#') {
      $error = 'Perl-style comments are not allowed; use "// Comment" instead';
      $phpcsFile
        ->addError($error, $stackPtr, 'WrongStyle');
    }
    $comment = rtrim($tokens[$stackPtr]['content']);

    // Only want inline comments.
    if (substr($comment, 0, 2) !== '//') {
      return;
    }

    // Ignore code example lines.
    if ($this
      ->isInCodeExample($phpcsFile, $stackPtr) === true) {
      return;
    }

    // Verify the indentation of this comment line.
    $this
      ->processIndentation($phpcsFile, $stackPtr);

    // The below section determines if a comment block is correctly capitalised,
    // and ends in a full-stop. It will find the last comment in a block, and
    // work its way up.
    $nextComment = $phpcsFile
      ->findNext(array(
      T_COMMENT,
    ), $stackPtr + 1, null, false);
    if ($nextComment !== false && $tokens[$nextComment]['line'] === $tokens[$stackPtr]['line'] + 1) {
      return;
    }
    $topComment = $stackPtr;
    $lastComment = $stackPtr;
    while (($topComment = $phpcsFile
      ->findPrevious(array(
      T_COMMENT,
    ), $lastComment - 1, null, false)) !== false) {
      if ($tokens[$topComment]['line'] !== $tokens[$lastComment]['line'] - 1) {
        break;
      }
      $lastComment = $topComment;
    }
    $topComment = $lastComment;
    $commentText = '';
    for ($i = $topComment; $i <= $stackPtr; $i++) {
      if ($tokens[$i]['code'] === T_COMMENT) {
        $commentText .= trim(substr($tokens[$i]['content'], 2));
      }
    }
    if ($commentText === '') {
      $error = 'Blank comments are not allowed';
      $phpcsFile
        ->addError($error, $stackPtr, 'Empty');
      return;
    }
    $words = preg_split('/\\s+/', $commentText);
    if ($commentText[0] !== strtoupper($commentText[0])) {

      // Allow special lower cased words that contain non-alpha characters
      // (function references, machine names with underscores etc.).
      $matches = array();
      preg_match('/[a-z]+/', $words[0], $matches);
      if ($matches[0] === $words[0]) {
        $error = 'Inline comments must start with a capital letter';
        $phpcsFile
          ->addError($error, $topComment, 'NotCapital');
      }
    }
    $commentCloser = $commentText[strlen($commentText) - 1];
    $acceptedClosers = array(
      'full-stops' => '.',
      'exclamation marks' => '!',
      'or question marks' => '?',
    );
    if (in_array($commentCloser, $acceptedClosers) === false) {

      // Allow @tag style comments without punctuation
      $firstWord = $words[0];
      if (strpos($firstWord, '@') !== 0) {

        // Allow special last words like URLs or function references
        // without punctuation.
        $lastWord = $words[count($words) - 1];
        $matches = array();
        preg_match('/((\\()?[$a-zA-Z]+\\)|([$a-zA-Z]+))/', $lastWord, $matches);
        if (isset($matches[0]) === true && $matches[0] === $lastWord) {
          $error = 'Inline comments must end in %s';
          $ender = '';
          foreach ($acceptedClosers as $closerName => $symbol) {
            $ender .= $closerName . ', ';
          }
          $ender = rtrim($ender, ', ');
          $data = array(
            $ender,
          );
          $phpcsFile
            ->addError($error, $stackPtr, 'InvalidEndChar', $data);
        }
      }
    }
  }

  //end process()

  /**
   * Determines if a comment line is part of an @code/@endcode example.
   *
   * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
   * @param int                  $stackPtr  The position of the current token
   *                                        in the stack passed in $tokens.
   *
   * @return boolean Returns true if the comment line is within a @code block,
   *                 false otherwise.
   */
  protected function isInCodeExample(PHP_CodeSniffer_File $phpcsFile, $stackPtr) {
    $tokens = $phpcsFile
      ->getTokens();
    $prevComment = $stackPtr;
    $lastComment = $stackPtr;
    while (($prevComment = $phpcsFile
      ->findPrevious(array(
      T_COMMENT,
    ), $lastComment - 1, null, false)) !== false) {
      if ($tokens[$prevComment]['line'] !== $tokens[$lastComment]['line'] - 1) {
        return false;
      }
      if ($tokens[$prevComment]['content'] === '// @code' . $phpcsFile->eolChar) {
        return true;
      }
      if ($tokens[$prevComment]['content'] === '// @endcode' . $phpcsFile->eolChar) {
        return false;
      }
      $lastComment = $prevComment;
    }
    return false;
  }

  //end isInCodeExample()

  /**
   * Checks the indentation level of the comment contents.
   *
   * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
   * @param int                  $stackPtr  The position of the current token
   *                                        in the stack passed in $tokens.
   *
   * @return void
   */
  protected function processIndentation(PHP_CodeSniffer_File $phpcsFile, $stackPtr) {
    $tokens = $phpcsFile
      ->getTokens();
    $comment = rtrim($tokens[$stackPtr]['content']);
    $spaceCount = 0;
    for ($i = 2; $i < strlen($comment); $i++) {
      if ($comment[$i] !== ' ') {
        break;
      }
      $spaceCount++;
    }
    if ($spaceCount === 0 && strlen($comment) > 2) {
      $error = 'No space before comment text; expected "// %s" but found "%s"';
      $data = array(
        substr($comment, 2),
        $comment,
      );
      $phpcsFile
        ->addError($error, $stackPtr, 'NoSpaceBefore', $data);
    }
    if ($spaceCount > 1) {

      // Check if there is a comment on the previous line that justifies the
      // indentation.
      $prevComment = $phpcsFile
        ->findPrevious(array(
        T_COMMENT,
      ), $stackPtr - 1, null, false);
      if ($prevComment !== false && $tokens[$prevComment]['line'] === $tokens[$stackPtr]['line'] - 1) {
        $prevCommentText = rtrim($tokens[$prevComment]['content']);
        $prevSpaceCount = 0;
        for ($i = 2; $i < strlen($prevCommentText); $i++) {
          if ($prevCommentText[$i] !== ' ') {
            break;
          }
          $prevSpaceCount++;
        }
        if ($spaceCount > $prevSpaceCount && $prevSpaceCount > 0) {

          // A previous comment could be a list item or @todo.
          $indentationStarters = array(
            '-',
            '@todo',
          );
          $words = preg_split('/\\s+/', $prevCommentText);
          if (in_array($words[1], $indentationStarters) === true) {
            if ($spaceCount !== $prevSpaceCount + 2) {
              $error = 'Comment indentation error after %s element, expected %s spaces';
              $phpcsFile
                ->addError($error, $stackPtr, 'SpacingBefore', array(
                $words[1],
                $prevSpaceCount + 2,
              ));
            }
          }
          else {
            $error = 'Comment indentation error, expected only %s spaces';
            $phpcsFile
              ->addError($error, $stackPtr, 'SpacingBefore', array(
              $prevSpaceCount,
            ));
          }
        }
      }
      else {
        $error = '%s spaces found before inline comment; expected "// %s" but found "%s"';
        $data = array(
          $spaceCount,
          substr($comment, 2 + $spaceCount),
          $comment,
        );
        $phpcsFile
          ->addError($error, $stackPtr, 'SpacingBefore', $data);
      }

      //end if
    }

    //end if
  }

}

Members

Name	Modifiers	Type	Description
Drupal_Sniffs_Commenting_InlineCommentSniff::isInCodeExample	protected	function	Determines if a comment line is part of an
Drupal_Sniffs_Commenting_InlineCommentSniff::process	public	function	Processes this test, when one of its tokens is encountered.
Drupal_Sniffs_Commenting_InlineCommentSniff::processIndentation	protected	function	Checks the indentation level of the comment contents.
Drupal_Sniffs_Commenting_InlineCommentSniff::register	public	function	Returns an array of tokens this test wants to listen for.

You are here

class Drupal_Sniffs_Commenting_InlineCommentSniff in Coder 7.2

Hierarchy

File

Members

API Navigation