function coder_review_sql_reviews in Coder 7
Same name and namespace in other branches
- 7.2 coder_review/includes/coder_review_sql.inc \coder_review_sql_reviews()
Implements hook_reviews().
File
- coder_review/
includes/ coder_review_sql.inc, line 11 - This include file implements coder functionality for SQL strings
Code
function coder_review_sql_reviews() {
$table = '\\{[A-Za-z_]+\\}';
// table-regex
$bad = '[A-Za-z_]+';
$rules = array(
// NOTE: this doesn't catch all non-upper case keywords, but is a good start
array(
'#type' => 'regex',
'#value' => '^(select\\s+.*\\s+from\\s+' . $table . '|insert\\s+into\\s+' . $table . '|update\\s+' . $table . '\\s+set|delete\\s+from\\s+' . $table . ')',
'#source' => 'quote',
'#warning' => 'SQL keywords should be upper case',
'#case-sensitive' => TRUE,
'#severity' => 'minor',
),
array(
'#type' => 'regex',
'#value' => '^(select\\s+.*\\s+from\\s+' . $bad . '|insert\\s+into\\s+' . $bad . '|update\\s+' . $bad . '\\s+set|delete\\s+from\\s' . $bad . ')',
'#source' => 'quote',
'#warning' => 'table names should be enclosed in {curly_brackets}',
'#severity' => 'critical',
),
array(
'#type' => 'regex',
'#value' => '^(select\\s+.*\\s+from\\s+' . $table . '|insert\\s+into\\s+' . $table . ')\\s+.*[Ll][Ii][Mm][Ii][Tt]\\s[0-9]+',
'#source' => 'quote',
'#warning_callback' => '_coder_review_sql_db_query_range_warning',
),
array(
'#type' => 'regex',
'#value' => '^(select\\s+.*\\s+from\\s+' . $table . '|update\\s+' . $table . '\\s+set|delete\\s+from\\s' . $table . ')\\s+.*!=',
'#source' => 'quote',
'#warning' => 'Use ANSI standard <> instead of !=',
),
array(
'#type' => 'regex',
'#value' => '^(select\\s+.*\\s+from\\s+' . $table . '\\s+.+?=\\s*`|insert\\s+into\\s+' . $table . '\\s+.*?VALUES\\s*(\\(\\s*`|\\(.*?,\\s*`)|update\\s+' . $table . '\\s+set\\s+.*?=\\s*`|delete\\s+from\\s' . $table . '\\s+.*?=\\s*`)',
'#source' => 'quote',
'#warning' => "Don't use back ticks to quote values as it is not compliant with ANSI SQL",
),
array(
'#type' => 'regex',
'#source' => 'allphp',
'#value' => 'db_query\\s*\\(\\s*[\'"]select\\s+count\\s*\\(\\s*\\*\\s*\\)\\s+from\\s+',
'#warning_callback' => '_coder_review_sql_select_count_warning',
'#severity' => 'minor',
),
);
$review = array(
'#title' => t('Drupal SQL Standards'),
'#rules' => $rules,
'#description' => t('Somewhat obsolete review, needs updating to DBTNG.'),
);
return array(
'sql' => $review,
);
}