RoutingAccessSniff.php in Coder 8.2
File
coder_sniffer/DrupalPractice/Sniffs/Yaml/RoutingAccessSniff.php
View source
<?php
namespace DrupalPractice\Sniffs\Yaml;
use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Sniffs\Sniff;
class RoutingAccessSniff implements Sniff {
public function register() {
return array(
T_INLINE_HTML,
);
}
public function process(File $phpcsFile, $stackPtr) {
$tokens = $phpcsFile
->getTokens();
$fileExtension = strtolower(substr($phpcsFile
->getFilename(), -12));
if ($fileExtension !== '.routing.yml') {
return $phpcsFile->numTokens + 1;
}
if (preg_match('/^[\\s]+_access: \'TRUE\'/', $tokens[$stackPtr]['content']) === 1 && isset($tokens[$stackPtr - 1]) === true && preg_match('/^[\\s]*#/', $tokens[$stackPtr - 1]['content']) === 0) {
$warning = 'Open page callback found, please add a comment before the line why there is no access restriction';
$phpcsFile
->addWarning($warning, $stackPtr, 'OpenCallback');
}
if (preg_match('/^[\\s]+_permission: \'access administration pages\'/', $tokens[$stackPtr]['content']) === 1) {
$warning = 'The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.';
$phpcsFile
->addWarning($warning, $stackPtr, 'PermissionFound');
}
}
}
Classes
Name |
Description |
RoutingAccessSniff |
Checks that there are no undocumented open access callbacks in *.routing.yml files. |