security_review.inc in Acquia Connector 7.3
Same filename and directory in other branches
Stand-alone security checks and review system.
File
acquia_spi/security_review.incView source
<?php
/**
* @file
* Stand-alone security checks and review system.
*/
/**
* Public function for running Security Review checklist and returning results.
*
* @param array $checklist
* Array of checks to run, indexed by module namespace.
* @param bool $log
* Whether to log check processing using security_review_log.
* @param bool $help
* Whether to load the help file and include in results.
*
* @return array
* Results from running checklist, indexed by module namespace.
*/
function acquia_spi_security_review_run(array $checklist = NULL, $log = FALSE, $help = FALSE) {
// Use Security Review module if available.
if (module_exists('security_review') && function_exists('security_review_run')) {
if (!$checklist) {
$checklist = module_invoke_all('security_checks');
}
module_load_include('inc', 'security_review');
return security_review_run($checklist, $log, $help);
}
else {
return _acquia_spi_security_review_run($checklist, $log);
}
}
/**
* Private function the review and returns the full results.
*/
function _acquia_spi_security_review_run($checklist, $log = FALSE) {
$results = array();
foreach ($checklist as $module => $checks) {
foreach ($checks as $check_name => $arguments) {
$check_result = _acquia_spi_security_review_run_check($module, $check_name, $arguments, $log);
if (!empty($check_result)) {
$results[$module][$check_name] = $check_result;
}
}
}
return $results;
}
/**
* Run a single Security Review check.
*/
function _acquia_spi_security_review_run_check($module, $check_name, $check, $log, $store = FALSE) {
$last_check = array();
$check_result = array();
$return = array(
'result' => NULL,
);
if (isset($check['file'])) {
// Handle Security Review defining checks for other modules.
if (isset($check['module'])) {
$module = $check['module'];
}
module_load_include('inc', $module, $check['file']);
}
$function = $check['callback'];
if (function_exists($function)) {
$return = call_user_func($function, $last_check);
}
$check_result = array_merge($check, $return);
$check_result['lastrun'] = REQUEST_TIME;
// Do not log if result is NULL.
if ($log && !is_null($return['result'])) {
$variables = array(
'!name' => $check_result['title'],
);
if ($check_result['result']) {
_acquia_spi_security_review_log($module, $check_name, '!name check passed', $variables, WATCHDOG_INFO);
}
else {
_acquia_spi_security_review_log($module, $check_name, '!name check failed', $variables, WATCHDOG_ERROR);
}
}
return $check_result;
}
/**
* Checks for acquia_spi_security_review_get_checks().
*/
function _acquia_spi_security_review_security_checks() {
$checks['file_perms'] = array(
'title' => t('File system permissions'),
'callback' => 'acquia_spi_security_review_check_file_perms',
'success' => t('Drupal installation files and directories (except required) are not writable by the server.'),
'failure' => t('Some files and directories in your install are writable by the server.'),
);
$checks['input_formats'] = array(
'title' => t('Text formats'),
'callback' => 'acquia_spi_security_review_check_input_formats',
'success' => t('Untrusted users are not allowed to input dangerous HTML tags.'),
'failure' => t('Untrusted users are allowed to input dangerous HTML tags.'),
);
$checks['field'] = array(
'title' => t('Content'),
'callback' => 'acquia_spi_security_review_check_field',
'success' => t('Dangerous tags were not found in any submitted content (fields).'),
'failure' => t('Dangerous tags were found in submitted content (fields).'),
);
$checks['error_reporting'] = array(
'title' => t('Error reporting'),
'callback' => 'acquia_spi_security_review_check_error_reporting',
'success' => t('Error reporting set to log only.'),
'failure' => t('Errors are written to the screen.'),
);
$checks['private_files'] = array(
'title' => t('Private files'),
'callback' => 'acquia_spi_security_review_check_private_files',
'success' => t('Private files directory is outside the web server root.'),
'failure' => t('Private files is enabled but the specified directory is not secure outside the web server root.'),
);
// Checks dependent on dblog.
if (module_exists('dblog')) {
$checks['query_errors'] = array(
'title' => t('Database errors'),
'callback' => 'acquia_spi_security_review_check_query_errors',
'success' => t('Few query errors from the same IP.'),
'failure' => t('Query errors from the same IP. These may be a SQL injection attack or an attempt at information disclosure.'),
);
$checks['failed_logins'] = array(
'title' => t('Failed logins'),
'callback' => 'acquia_spi_security_review_check_failed_logins',
'success' => t('Few failed login attempts from the same IP.'),
'failure' => t('Failed login attempts from the same IP. These may be a brute-force attack to gain access to your site.'),
);
}
$checks['upload_extensions'] = array(
'title' => t('Allowed upload extensions'),
'callback' => 'acquia_spi_security_review_check_upload_extensions',
'success' => t('Only safe extensions are allowed for uploaded files and images.'),
'failure' => t('Unsafe file extensions are allowed in uploads.'),
);
$checks['admin_permissions'] = array(
'title' => t('Drupal permissions'),
'callback' => 'acquia_spi_security_review_check_admin_permissions',
'success' => t('Untrusted roles do not have administrative or trusted Drupal permissions.'),
'failure' => t('Untrusted roles have been granted administrative or trusted Drupal permissions.'),
);
// Check dependent on PHP filter being enabled.
if (module_exists('php')) {
$checks['untrusted_php'] = array(
'title' => t('PHP access'),
'callback' => 'acquia_spi_security_review_check_php_filter',
'success' => t('Untrusted users do not have access to use the PHP input format.'),
'failure' => t('Untrusted users have access to use the PHP input format.'),
);
}
$checks['executable_php'] = array(
'title' => t('Executable PHP'),
'callback' => 'acquia_spi_security_review_check_executable_php',
'success' => t('PHP files in the Drupal files directory cannot be executed.'),
'failure' => t('PHP files in the Drupal files directory can be executed.'),
);
$checks['base_url_set'] = array(
'title' => t('Drupal base URL'),
'callback' => 'acquia_spi_security_review_check_base_url',
'success' => t('Base URL is set in settings.php.'),
'failure' => t('Base URL is not set in settings.php.'),
);
$checks['temporary_files'] = array(
'title' => t('Temporary files'),
'callback' => 'acquia_spi_security_review_check_temporary_files',
'success' => t('No sensitive temporary files were found.'),
'failure' => t('Sensitive temporary files were found on your files system.'),
);
if (module_exists('views') && function_exists('views_get_all_views')) {
$checks['views_access'] = array(
'title' => t('Views access'),
'callback' => 'acquia_spi_security_review_check_views_access',
'success' => t('Views are access controlled.'),
'failure' => t('There are Views that do not provide any access checks.'),
);
}
return array(
'security_review' => $checks,
);
}
/**
* Check that files aren't writeable by the server.
*/
function acquia_spi_security_review_check_file_perms() {
$result = TRUE;
// Extract ending folder for file directory path.
$file_path = './' . rtrim(variable_get('file_public_path', conf_path() . '/files'), '/');
// Set files to ignore.
$ignore = array(
'..',
'CVS',
'.git',
'.svn',
'.bzr',
$file_path,
);
// Add private files directory if it's set.
$private_files = variable_get('file_private_path', '');
if (!empty($private_files)) {
$private_files = substr($private_files, strrpos($private_files, '/') + 1);
$ignore[] = $private_files;
}
drupal_alter('security_review_file_ignore', $ignore);
$files = _acquia_spi_security_review_check_file_perms_scan('.', $ignore);
// Try creating or appending files.
// Assume it doesn't work.
$create_status = $append_status = FALSE;
$directory = drupal_get_path('module', 'security_review');
// Write a file with the timestamp.
$file = './' . $directory . '/file_write_test.' . date('Ymdhis');
if ($file_create = @fopen($file, 'w')) {
$create_status = fwrite($file_create, t("This is a vulnerable directory.\n"));
fclose($file_create);
}
// Try to append to our IGNOREME file.
$file = './' . $directory . '/IGNOREME.txt';
if ($file_append = @fopen($file, 'a')) {
$append_status = fwrite($file_append, date('Ymdhis') . "\n");
fclose($file_append);
}
if (count($files) || $create_status || $append_status) {
$result = FALSE;
}
return array(
'result' => $result,
'value' => $files,
);
}
/**
* Needs comment.
*/
function _acquia_spi_security_review_check_file_perms_scan($directory, $ignore) {
$items = array();
if ($handle = opendir($directory)) {
while (($file = readdir($handle)) !== FALSE) {
// Don't check hidden files or ones we said to ignore.
if ($file[0] != "." && !in_array($file, $ignore)) {
$file = $directory . "/" . $file;
if (is_dir($file) && !in_array($file, $ignore)) {
$items = array_merge($items, _acquia_spi_security_review_check_file_perms_scan($file, $ignore));
if (is_writable($file)) {
$items[] = preg_replace("/\\/\\//si", "/", $file);
}
}
elseif (is_writable($file) && !in_array($file, $ignore)) {
$items[] = preg_replace("/\\/\\//si", "/", $file);
}
}
}
closedir($handle);
}
return $items;
}
/**
* Check input formats.
*
* Check for formats that either do not have HTML filter that can be used by
* untrusted users, or if they do check if unsafe tags are allowed.
*/
function acquia_spi_security_review_check_input_formats() {
$result = TRUE;
$formats = filter_formats();
$check_result_value = array();
// Check formats that are accessible by untrusted users.
$untrusted_roles = acquia_spi_security_review_untrusted_roles();
$untrusted_roles = array_keys($untrusted_roles);
foreach ($formats as $id => $format) {
$format_roles = filter_get_roles_by_format($format);
$intersect = array_intersect(array_keys($format_roles), $untrusted_roles);
if (!empty($intersect)) {
// Untrusted users can use this format.
$filters = filter_list_format($format->format);
// Check format for enabled HTML filter.
if (in_array('filter_html', array_keys($filters)) && $filters['filter_html']->status) {
$filter = $filters['filter_html'];
// Check for unsafe tags in allowed tags.
$allowed_tags = $filter->settings['allowed_html'];
$unsafe_tags = acquia_spi_security_review_unsafe_tags();
foreach ($unsafe_tags as $tag) {
if (strpos($allowed_tags, '<' . $tag . '>') !== FALSE) {
// Found an unsafe tag.
$check_result_value['tags'][$id] = $tag;
}
}
}
elseif (!in_array('filter_html_escape', array_keys($filters)) || !$filters['filter_html_escape']->status) {
// Format is usable by untrusted users but does not contain the HTML
// Filter or the HTML escape.
$check_result_value['formats'][$id] = $format;
}
}
}
if (!empty($check_result_value)) {
$result = FALSE;
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_php_filter() {
$result = TRUE;
$formats = filter_formats();
$check_result_value = array();
// Check formats that are accessible by untrusted users.
$untrusted_roles = acquia_spi_security_review_untrusted_roles();
$untrusted_roles = array_keys($untrusted_roles);
foreach ($formats as $id => $format) {
$format_roles = filter_get_roles_by_format($format);
$intersect = array_intersect(array_keys($format_roles), $untrusted_roles);
if (!empty($intersect)) {
// Untrusted users can use this format.
$filters = filter_list_format($format->format);
// Check format for enabled PHP filter.
if (in_array('php_code', array_keys($filters)) && $filters['php_code']->status) {
$result = FALSE;
$check_result_value['formats'][$id] = $format;
}
}
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_error_reporting() {
$error_level = variable_get('error_level', NULL);
if (is_null($error_level) || intval($error_level) >= 1) {
// When the variable isn't set, or its set to 1 or 2 errors are printed to
// the screen.
$result = FALSE;
}
else {
$result = TRUE;
}
return array(
'result' => $result,
);
}
/**
* If private files is enabled check that the directory is not under web root.
*
* There is ample room for the user to get around this check.
*
* @TODO get more sophisticated?
*/
function acquia_spi_security_review_check_private_files() {
$file_directory_path = variable_get('file_private_path', '');
if (empty($file_directory_path)) {
// Ignore this check.
$result = NULL;
}
elseif (strpos(realpath($file_directory_path), DRUPAL_ROOT) === 0) {
// Path begins at root.
$result = FALSE;
}
else {
$result = TRUE;
}
return array(
'result' => $result,
'value' => $file_directory_path,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_query_errors($last_check = NULL) {
$timestamp = NULL;
$check_result_value = array();
$query = db_select('watchdog', 'w')
->fields('w', array(
'message',
'hostname',
))
->condition('type', 'php')
->condition('severity', WATCHDOG_ERROR);
if (isset($last_check['lastrun'])) {
$query
->condition('timestamp', $last_check['lastrun'], '>=');
}
$result = $query
->execute();
foreach ($result as $row) {
if (strpos($row->message, 'SELECT') !== FALSE) {
$entries[$row->hostname][] = $row;
}
}
$result = TRUE;
if (!empty($entries)) {
foreach ($entries as $ip => $records) {
if (count($records) > 10) {
$check_result_value[] = $ip;
}
}
}
if (!empty($check_result_value)) {
$result = FALSE;
}
else {
// Rather than worrying the user about the idea of query errors we skip
// reporting a pass.
$result = NULL;
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_failed_logins($last_check = NULL) {
$result = TRUE;
$timestamp = NULL;
$check_result_value = array();
$query = db_select('watchdog', 'w')
->fields('w', array(
'message',
'hostname',
))
->condition('type', 'php')
->condition('severity', WATCHDOG_NOTICE);
if (isset($last_check['lastrun'])) {
$query
->condition('timestamp', $last_check['lastrun'], '>=');
}
$result = $query
->execute();
foreach ($result as $row) {
if (strpos($row->message, 'Login attempt failed') !== FALSE) {
$entries[$row->hostname][] = $row;
}
}
if (!empty($entries)) {
foreach ($entries as $ip => $records) {
if (count($records) > 10) {
$check_result_value[] = $ip;
}
}
}
if (!empty($check_result_value)) {
$result = FALSE;
}
else {
// Rather than worrying the user about the idea of failed logins we skip
// reporting a pass.
$result = NULL;
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Look for admin permissions granted to untrusted roles.
*/
function acquia_spi_security_review_check_admin_permissions() {
$result = TRUE;
$check_result_value = array();
$untrusted_roles = acquia_spi_security_review_untrusted_roles();
// Collect permissions marked as for trusted users only.
$all_permissions = module_invoke_all('permission');
$all_keys = array_keys($all_permissions);
// Get permissions for untrusted roles.
$untrusted_permissions = user_role_permissions($untrusted_roles);
foreach ($untrusted_permissions as $rid => $permissions) {
$intersect = array_intersect($all_keys, array_keys($permissions));
foreach ($intersect as $permission) {
if (!empty($all_permissions[$permission]['restrict access'])) {
$check_result_value[$rid][] = $permission;
}
}
}
if (!empty($check_result_value)) {
$result = FALSE;
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_field($last_check = NULL) {
$check_result = TRUE;
$check_result_value = $tables = $found = array();
$timestamp = NULL;
$instances = field_info_instances();
// Loop through instances checking for fields of type text.
foreach ($instances as $entity_type => $type_bundles) {
foreach ($type_bundles as $bundle => $bundle_instances) {
foreach ($bundle_instances as $field_name => $instance) {
$field = field_info_field($field_name);
// Check into text fields that are stored in SQL.
if ($field['module'] == 'text' && $field['storage']['module'] == 'field_sql_storage') {
// Build array of tables and columns to search.
$current_table = key($field['storage']['details']['sql'][FIELD_LOAD_CURRENT]);
$revision_table = key($field['storage']['details']['sql'][FIELD_LOAD_REVISION]);
if (!array_key_exists($current_table, $tables)) {
$tables[$current_table] = $field['storage']['details']['sql'][FIELD_LOAD_CURRENT][$current_table]['value'];
}
if (!array_key_exists($revision_table, $tables)) {
$tables[$revision_table] = $field['storage']['details']['sql'][FIELD_LOAD_REVISION][$revision_table]['value'];
}
}
}
}
}
if (empty($tables)) {
return array(
'result' => $check_result,
'value' => $check_result_value,
);
}
// Search for PHP or Javascript tags in text columns.
foreach ($tables as $table => $column) {
$sql = "SELECT DISTINCT entity_id, entity_type FROM {" . $table . "} WHERE " . $column . " LIKE :text";
// Handle changed? @todo
foreach (array(
'Javascript' => '%<script%',
'PHP' => '%<?php%',
) as $description => $comparison) {
// @pager query?
$results = db_query($sql, array(
':text' => $comparison,
));
foreach ($results as $result) {
$check_result = FALSE;
if (!isset($check_result_value[$result->entity_type]) || !array_key_exists($result->entity_id, $check_result_value[$result->entity_type])) {
$check_result_value[$result->entity_type][$result->entity_id] = $description;
}
}
}
}
return array(
'result' => $check_result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_upload_extensions($last_check = NULL) {
$check_result = TRUE;
$check_result_value = array();
$instances = field_info_instances();
$unsafe_extensions = acquia_spi_security_review_unsafe_extensions();
// Loop through instances checking for fields of file.
foreach ($instances as $entity_type => $type_bundles) {
foreach ($type_bundles as $bundle => $bundle_instances) {
foreach ($bundle_instances as $field_name => $instance) {
$field = field_info_field($field_name);
if ($field['module'] == 'image' || $field['module'] == 'file') {
// Check instance file_extensions.
foreach ($unsafe_extensions as $unsafe_extension) {
if (strpos($instance['settings']['file_extensions'], $unsafe_extension) !== FALSE) {
// Found an unsafe extension.
$check_result_value[$instance['field_name']][$instance['bundle']] = $unsafe_extension;
$check_result = FALSE;
}
}
}
}
}
}
return array(
'result' => $check_result,
'value' => $check_result_value,
);
}
/**
* Check if PHP files written to the files directory can be executed.
*/
function acquia_spi_security_review_check_executable_php($last_check = NULL) {
global $base_url;
$result = TRUE;
$check_result_value = array();
$message = 'Security review test ' . date('Ymdhis');
$content = "<?php\necho '" . $message . "';";
$directory = variable_get('file_public_path', 'sites/default/files');
$file = '/security_review_test.php';
if ($file_create = @fopen('./' . $directory . $file, 'w')) {
$create_status = fwrite($file_create, $content);
fclose($file_create);
}
$response = drupal_http_request($base_url . '/' . $directory . $file);
if ($response->code == 200 && $response->data === $message) {
$result = FALSE;
$check_result_value[] = 'executable_php';
}
if (file_exists('./' . $directory . $file)) {
@unlink('./' . $directory . $file);
}
// Check for presence of the .htaccess file and if the contents are correct.
if (!file_exists($directory . '/.htaccess')) {
$result = FALSE;
$check_result_value[] = 'missing_htaccess';
}
elseif (!function_exists('file_htaccess_lines')) {
$result = FALSE;
$check_result_value[] = 'outdated_core';
}
else {
if (!_acquia_spi_security_review_htaccess_analyze($directory)) {
$result = FALSE;
$check_result_value[] = 'incorrect_htaccess';
}
if (is_writable($directory . '/.htaccess')) {
// Don't modify $result.
$check_result_value[] = 'writable_htaccess';
}
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Helper function to analyze .htaccess in specified directory.
*
* @param string $directory
* Directory to analyze.
*
* @return bool
* True or false.
*/
function _acquia_spi_security_review_htaccess_analyze($directory) {
$contents = file_get_contents($directory . '/.htaccess');
// Text from includes/file.inc.
$expected = file_htaccess_lines(FALSE);
if (trim($contents) !== trim($expected)) {
$expected = _acquia_spi_security_review_htaccess_parse($expected);
$contents = _acquia_spi_security_review_htaccess_parse($contents);
if (!empty($expected) && !empty($contents)) {
foreach ($expected as $key => $value) {
if (is_array($value)) {
if (!isset($contents[$key])) {
return FALSE;
}
foreach ($value as $k => $v) {
if (array_search($v, $contents[$key]) === FALSE) {
return FALSE;
}
}
}
else {
if (array_search($value, $contents) === FALSE) {
return FALSE;
}
}
}
}
else {
return FALSE;
}
}
return TRUE;
}
/**
* Helper function to parse .htaccess data into nested array.
*
* @param string $htaccess
* Contents of .htaccess file.
*
* @return array
* Array of parsed data. Nested sections converted into two-dimensional array.
*/
function _acquia_spi_security_review_htaccess_parse($htaccess) {
$result = array();
// Remove full-line comments.
$htaccess = preg_replace('/^\\s*#.*$/mui', '', $htaccess);
$htaccess = explode("\n", $htaccess);
$section = array();
$section_key = array();
foreach ($htaccess as $key => $value) {
$value = trim($value);
if ($value) {
// .htaccess section begin
if (preg_match('/^<([^\\s]+)\\s+(.+)>.*$/ui', $value, $regs)) {
$section[] = strtolower($regs[1]);
$section_key[] = strtolower($regs[1]) . '-' . strtolower($regs[2]);
}
elseif (count($section) && preg_match('/^<\\/' . preg_quote($section[count($section) - 1], '/') . '>.*$/ui', $value, $regs)) {
array_pop($section);
array_pop($section_key);
}
else {
$value = preg_replace(array(
'/\\s*#.+/ui',
'/\\s+/ui',
), array(
'',
' ',
), $value);
if (count($section)) {
$result[implode('-', $section_key)][] = $value;
}
else {
$result[] = $value;
}
}
}
}
return $result;
}
/**
* Check if $base_url is set in settings.php.
*/
function acquia_spi_security_review_check_base_url($last_check = NULL) {
// Support different methods to check for $base_url.
$method = variable_get('security_review_base_url_method', 'token');
$result = NULL;
if ($method === 'token') {
if (file_exists(DRUPAL_ROOT . '/' . conf_path() . '/settings.php')) {
$content = file_get_contents(DRUPAL_ROOT . '/' . conf_path() . '/settings.php');
$tokens = token_get_all($content);
}
$result = FALSE;
foreach ($tokens as $token) {
if (is_array($token) && $token[0] === T_VARIABLE && $token[1] == '$base_url') {
$result = TRUE;
break;
}
}
}
elseif ($method === 'include') {
if (file_exists(DRUPAL_ROOT . '/' . conf_path() . '/settings.php')) {
include DRUPAL_ROOT . '/' . conf_path() . '/settings.php';
}
if (isset($base_url)) {
$result = TRUE;
}
else {
$result = FALSE;
}
}
return array(
'result' => $result,
'value' => '',
);
}
/**
* Check for sensitive temporary files like settings.php~.
*/
function acquia_spi_security_review_check_temporary_files($last_check = NULL) {
$result = TRUE;
$check_result_value = array();
$files = array();
$dir = scandir(DRUPAL_ROOT . '/' . conf_path() . '/');
foreach ($dir as $file) {
// Set full path to only files.
if (!is_dir($file)) {
$files[] = DRUPAL_ROOT . '/' . conf_path() . '/' . $file;
}
}
drupal_alter('security_review_temporary_files', $files);
foreach ($files as $path) {
$matches = array();
if (file_exists($path) && preg_match('/.*(~|\\.sw[op]|\\.bak|\\.orig|\\.save)$/', $path, $matches) !== FALSE && !empty($matches)) {
$result = FALSE;
$check_result_value[] = $path;
}
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Needs comment.
*/
function acquia_spi_security_review_check_views_access($last_check = NULL) {
$result = TRUE;
$check_result_value = array();
$timestamp = NULL;
// Load and loop through every view, checking the access type in displays.
$views = views_get_all_views();
foreach ($views as $view) {
if ($view->disabled !== TRUE) {
// Access is set in display options of a display.
foreach ($view->display as $display_name => $display) {
if (isset($display->display_options['access']) && $display->display_options['access']['type'] == 'none') {
$check_result_value[$view->name][] = $display_name;
}
}
}
}
if (!empty($check_result_value)) {
$result = FALSE;
}
return array(
'result' => $result,
'value' => $check_result_value,
);
}
/**
* Helper function allows for collection of this file's security checks.
*/
function acquia_spi_security_review_get_checks() {
// Use Security Review's checks if available.
if (module_exists('security_review') && function_exists('security_review_security_checks')) {
return module_invoke_all('security_checks');
}
else {
return _acquia_spi_security_review_security_checks();
}
}
/**
* Helper function defines HTML tags that are considered unsafe.
*
* Based on wysiwyg_filter_get_elements_blacklist().
*/
function acquia_spi_security_review_unsafe_tags() {
return array(
'applet',
'area',
'audio',
'base',
'basefont',
'body',
'button',
'comment',
'embed',
'eval',
'form',
'frame',
'frameset',
'head',
'html',
'iframe',
'image',
'img',
'input',
'isindex',
'label',
'link',
'map',
'math',
'meta',
'noframes',
'noscript',
'object',
'optgroup',
'option',
'param',
'script',
'select',
'style',
'svg',
'table',
'td',
'textarea',
'title',
'video',
'vmlframe',
);
}
/**
* Helper function defines file extensions considered unsafe.
*/
function acquia_spi_security_review_unsafe_extensions() {
return array(
'swf',
'exe',
'html',
'htm',
'php',
'phtml',
'py',
'js',
'vb',
'vbe',
'vbs',
);
}
/**
* Helper function defines the default untrusted Drupal roles.
*/
function _acquia_spi_security_review_default_untrusted_roles() {
$roles = array(
DRUPAL_ANONYMOUS_RID => t('anonymous user'),
);
$user_register = variable_get('user_register', 1);
// If visitors are allowed to create accounts they are considered untrusted.
if ($user_register != USER_REGISTER_ADMINISTRATORS_ONLY) {
$roles[DRUPAL_AUTHENTICATED_RID] = t('authenticated user');
}
return $roles;
}
/**
* Helper function for user-defined or default unstrusted Drupal roles.
*
* @return array
* An associative array with the role id as the key and the role name as
* value.
*/
function acquia_spi_security_review_untrusted_roles() {
$defaults = _acquia_spi_security_review_default_untrusted_roles();
$roles = variable_get('security_review_untrusted_roles', $defaults);
// array_filter() to remove roles with 0 (meaning they are trusted) @todo
return array_filter($roles);
}
/**
* Helper function collects the permissions untrusted roles have.
*/
function acquia_spi_security_review_untrusted_permissions() {
static $permissions;
if (empty($permissions)) {
$permissions = array();
// Collect list of untrusted roles' permissions.
$untrusted_roles = acquia_spi_security_review_untrusted_roles();
foreach ($untrusted_roles as $rid) {
$perms = array();
$results = db_query('SELECT r.rid, p.permission FROM {role} r LEFT JOIN {role_permission} p ON r.rid = p.rid WHERE r.rid = :rid', array(
':rid' => $rid,
))
->fetchArray();
if ($results !== FALSE) {
$perms = explode(',', str_replace(', ', ',', $results['permission']));
$permissions[$rid] = $perms;
}
}
}
return $permissions;
}
/**
* Helper function for assumed trusted roles.
*/
function acquia_spi_security_review_trusted_roles() {
$trusted_roles = array();
$untrusted_roles = acquia_spi_security_review_untrusted_roles();
$results = db_query('SELECT rid, name FROM {role} WHERE rid NOT IN (:rids)', array(
':rids' => $untrusted_roles,
));
foreach ($results as $role) {
$trusted_roles[$role->rid] = $role->name;
}
return array_filter($trusted_roles);
}
/**
* Check if role has been granted a permission.
*/
function acquia_spi_security_review_role_permission($rid, $permission) {
$return = FALSE;
$result = db_select('role_permission', 'p')
->fields('p', array(
'permission',
))
->condition('rid', $rid)
->execute()
->fetchField();
if ($result['permission'] && strpos($result['permission'], $permission) !== FALSE) {
$return = TRUE;
}
return $return;
}
/**
* Needs comment.
*/
function _acquia_spi_security_review_log($module, $check_name, $message, $variables, $type) {
module_invoke_all('acquia_spi_security_review_log', $module, $check_name, $message, $variables, $type);
}